Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 2106007: Fix dtoa for the LP64 model on 64-bit systems, where long is 64 bits (Closed)

Created:
10 years, 7 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix dtoa for the LP64 model on 64-bit systems, where long is 64 bits. dtoa.c:69 states: #define Long int on machines with 32-bit ints and 64-bit longs. This change was made in Chromium's version of dtoa in r21901. I don't know why this apparently hasn't caused a problem in v8 until now. I was unable to build a snapshot on x86_64 Mac without this change. BUG=706 TEST=x86_64 Mac GYP/Xcode-based Chromium build (still depends on other changes) Committed: http://code.google.com/p/v8/source/detail?r=4665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/third_party/dtoa/dtoa.c View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
10 years, 7 months ago (2010-05-14 18:41:37 UTC) #1
Mads Ager (chromium)
10 years, 7 months ago (2010-05-17 07:01:15 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698