Issue 2106001: Added cups development package depending on the version of linux....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2106001: Added cups development package depending on the version of linux.... (Closed)

Created:
10 years, 7 months ago by gene

Modified:
9 years, 6 months ago

Reviewers:
Michael Moss

CC:
chromium-reviews, M-A Ruel

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Fixed error. On Hardy (8.x) we should be choosing libcupsys2-dev BUG=none TEST=Please check that correct cups package gets installed.

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
	M	build/install-build-deps.sh	View	1	2 chunks	+14 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

gene

It looks like CUPS package changed it's name starting from 9.x We need to install ...

10 years, 7 months ago (2010-05-13 20:50:12 UTC) #1

gene

Fixed error in the previous version of the script. The logic should be: libcupsys2-dev for ...

10 years, 7 months ago (2010-05-14 00:35:00 UTC) #3

gene

typo: libcups2-dev for everything else On 2010/05/14 00:35:00, gene wrote: > Fixed error in the ...

10 years, 7 months ago (2010-05-14 01:00:11 UTC) #4

Michael Moss

10 years, 7 months ago (2010-05-14 03:12:06 UTC) #5

Submitted.

On Thu, May 13, 2010 at 6:00 PM,  <gene@chromium.org> wrote:
> typo: libcups2-dev for everything else
>
> On 2010/05/14 00:35:00, gene wrote:
>>
>> Fixed error in the previous version of the script. The logic should be:
>> libcupsys2-dev for Hardy, libcup2-dev for everything else
>
>
>
> http://codereview.chromium.org/2106001/show
>

Expand Messages | Collapse Messages