Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/browser/printing/print_job_worker.h

Issue 21057: Remove black magic and >100 lines. Unhook a lot of dead code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/print_job_unittest.cc ('k') | chrome/browser/printing/print_view_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job_worker.h
===================================================================
--- chrome/browser/printing/print_job_worker.h (revision 9138)
+++ chrome/browser/printing/print_job_worker.h (working copy)
@@ -25,7 +25,7 @@
// PrintJob always outlives its worker instance.
class PrintJobWorker : public base::Thread {
public:
- PrintJobWorker(PrintJobWorkerOwner* owner);
+ explicit PrintJobWorker(PrintJobWorkerOwner* owner);
~PrintJobWorker();
void SetNewOwner(PrintJobWorkerOwner* new_owner);
@@ -58,6 +58,10 @@
// ALL_PAGES_REQUESTED notification once done.
void RequestMissingPages();
+ protected:
+ // Retrieves the context for testing only.
+ PrintingContext& printing_context() { return printing_context_; }
+
private:
// The shared NotificationService service can only be accessed from the UI
// thread, so this class encloses the necessary information to send the
« no previous file with comments | « chrome/browser/printing/print_job_unittest.cc ('k') | chrome/browser/printing/print_view_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698