Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: chrome/browser/printing/print_job.h

Issue 21057: Remove black magic and >100 lines. Unhook a lot of dead code. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/printing/page_overlays_unittest.cc ('k') | chrome/browser/printing/print_job.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/printing/print_job.h
===================================================================
--- chrome/browser/printing/print_job.h (revision 9138)
+++ chrome/browser/printing/print_job.h (working copy)
@@ -38,15 +38,6 @@
public PrintJobWorkerOwner,
public MessageLoop::DestructionObserver {
public:
- // GetSettings() UI parameter.
- enum GetSettingsAskParam {
- DEFAULTS,
- ASK_USER,
- };
-
- // Create a standalone PrintJob. When initializing with this constructor,
- // Initialize() must not be called.
- PrintJob(PrintedPagesSource* source);
// Create a empty PrintJob. When initializing with this constructor,
// post-constructor initialization must be done with Initialize().
PrintJob();
@@ -68,6 +59,7 @@
virtual void Release() {
return base::RefCountedThreadSafe<PrintJob>::Release();
}
+
virtual void GetSettingsDone(const PrintSettings& new_settings,
PrintingContext::Result result);
virtual PrintJobWorker* DetachWorker(PrintJobWorkerOwner* new_owner);
@@ -78,14 +70,6 @@
// DestructionObserver
virtual void WillDestroyCurrentMessageLoop();
- // Initializes the printing context. This can be done synchronously or not. It
- // is fine to call this function multiple times to reinitialize the settings.
- // |parent_window| parameter will be the owner of the print setting dialog
- // box. It is unused when |ask_for_user_settings| is DEFAULTS. No-op if a
- // print job is active.
- void GetSettings(GetSettingsAskParam ask_user_for_settings,
- gfx::NativeView parent_window);
-
// Starts the actual printing. Signals the worker that it should begin to
// spool as soon as data is available.
void StartPrinting();
@@ -99,13 +83,6 @@
// Cancels printing job and stops the worker thread. Takes effect immediately.
void Cancel();
- // Requests all the missing pages in the PrintedDocument. Returns true if at
- // least one page has been requested. Returns false if there was not enough
- // information to request the missing pages, i.e.
- // document()->document_page_count() is not initialized or no page
- // has been requested.
- bool RequestMissingPages();
-
// Synchronously wait for the job to finish. It is mainly useful when the
// process is about to be shut down and we're waiting for the spooler to eat
// our data.
« no previous file with comments | « chrome/browser/printing/page_overlays_unittest.cc ('k') | chrome/browser/printing/print_job.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698