Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 2105016: AU: Common code to parse simple key/value store files (Closed)

Created:
10 years, 7 months ago by adlr
Modified:
9 years ago
Reviewers:
davidjames
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

AU: Common code to parse simple key/value store files We use a few files, like /etc/lsb-release, that have a simple key/value store format: each line is a key/value pair and the key/value are separated by '='. This change make some common code to parse (and assemble) these files, which is used in one place now but will be used in another place soon, too. BUG=None TEST=attached unittests

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -13 lines) Patch
M src/platform/update_engine/SConstruct View 2 chunks +2 lines, -0 lines 0 comments Download
M src/platform/update_engine/omaha_request_prep_action.cc View 2 chunks +7 lines, -13 lines 0 comments Download
A src/platform/update_engine/simple_key_value_store.h View 1 chunk +26 lines, -0 lines 0 comments Download
A src/platform/update_engine/simple_key_value_store.cc View 1 chunk +47 lines, -0 lines 1 comment Download
A src/platform/update_engine/simple_key_value_store_unittest.cc View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
adlr
10 years, 7 months ago (2010-05-21 20:08:46 UTC) #1
davidjames
10 years, 7 months ago (2010-05-21 21:40:53 UTC) #2
LGTM w/nit

http://codereview.chromium.org/2105016/diff/1/4
File src/platform/update_engine/simple_key_value_store.cc (right):

http://codereview.chromium.org/2105016/diff/1/4#newcode29
src/platform/update_engine/simple_key_value_store.cc:29: ret[it->substr(0, pos)]
= it->substr(pos + 1, it->size());
Do you mean just it->substr(pos + 1)?

Powered by Google App Engine
This is Rietveld 408576698