Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 21041: Refactor code for determining line position in a source file.... (Closed)

Created:
11 years, 10 months ago by Mikhail Naganov
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Refactor code for determining line position in a source file. 1. Make Script::line_ends initialization two-pass to avoid dynamic memory allocation 2. Get rid of the original code in messages.js and use Script::line_ends instead. Committed: http://code.google.com/p/v8/source/detail?r=1223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -79 lines) Patch
M src/accessors.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/accessors.cc View 1 chunk +19 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/messages.js View 10 chunks +18 lines, -55 lines 0 comments Download
M src/objects.cc View 1 chunk +28 lines, -20 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mikhail Naganov
11 years, 10 months ago (2009-02-04 10:09:51 UTC) #1
Søren Thygesen Gjesse
11 years, 10 months ago (2009-02-04 10:33:10 UTC) #2
On 2009/02/04 10:09:51, mikhail.naganov wrote:
> 

LGTM

Powered by Google App Engine
This is Rietveld 408576698