net/socket/socks_client_socket_pool.h - Issue 2104013: Revert r47395. Looks like it still crashes =/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/socket/socks_client_socket_pool.h

Issue 2104013: Revert r47395. Looks like it still crashes =/ (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/socket/socks_client_socket_pool.h

diff --git a/net/socket/socks_client_socket_pool.h b/net/socket/socks_client_socket_pool.h

index 5b91ad37b39992309cddadc2ea7be3043c1f311d..a786dc1125eb9c3ee89e23a800879065abf08eac 100644

--- a/net/socket/socks_client_socket_pool.h

+++ b/net/socket/socks_client_socket_pool.h

@@ -109,7 +109,8 @@ class SOCKSClientSocketPool : public ClientSocketPool {

int max_sockets_per_group,

const std::string& name,

const scoped_refptr<HostResolver>& host_resolver,

- const scoped_refptr<TCPClientSocketPool>& tcp_pool);

+ const scoped_refptr<TCPClientSocketPool>& tcp_pool,

+ NetworkChangeNotifier* network_change_notifier);

// ClientSocketPool methods:

virtual int RequestSocket(const std::string& group_name,