Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4018)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/net_internals/dataview.js

Issue 2104012: Fixed a TODO in data export of net-internals, added Chrome version and comman... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/dom_ui/net_internals_ui.cc ('k') | chrome/browser/resources/net_internals/main.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/net_internals/dataview.js
===================================================================
--- chrome/browser/resources/net_internals/dataview.js (revision 47684)
+++ chrome/browser/resources/net_internals/dataview.js (working copy)
@@ -39,10 +39,13 @@
text.push('Number of actively captured events: ' +
g_browser.getAllActivelyCapturedEvents().length);
text.push('');
- // TODO(eroman): fill this with proper values.
- text.push('Chrome version: ' + 'TODO');
- text.push('Command line switches: ' + 'TODO');
+ text.push('Chrome version: ' + ClientInfo.version +
+ ' (' + ClientInfo.official +
+ ' ' + ClientInfo.cl +
+ ') ' + ClientInfo.version_mod);
+ text.push('Command line switches: ' + ClientInfo.command_line);
+
text.push('');
text.push('----------------------------------------------');
text.push(' Proxy settings');
« no previous file with comments | « chrome/browser/dom_ui/net_internals_ui.cc ('k') | chrome/browser/resources/net_internals/main.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698