Chromium Code Reviews

Issue 2104006: Push/pop is just one peephole optimization. Puth them all... (Closed)

Created:
10 years, 7 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Mads Ager (chromium)
CC:
v8-dev
Visibility:
Public.

Description

Push/pop is just one peephole optimization. Puth them all under one flag. Also other cosmetic changes to peephole optimization. Committed: http://code.google.com/p/v8/source/detail?r=4663

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+30 lines, -43 lines)
M src/arm/assembler-arm.h View 1 chunk +6 lines, -0 lines 0 comments
M src/arm/assembler-arm.cc View 9 chunks +14 lines, -29 lines 0 comments
M src/flag-definitions.h View 1 chunk +0 lines, -4 lines 0 comments
M src/ia32/assembler-ia32.cc View 10 chunks +10 lines, -10 lines 0 comments

Messages

Total messages: 2 (0 generated)
Erik Corry
10 years, 7 months ago (2010-05-17 11:11:57 UTC) #1
Mads Ager (chromium)
10 years, 7 months ago (2010-05-17 11:14:46 UTC) #2
LGTM

Powered by Google App Engine