chrome/common/resource_dispatcher_unittest.cc - Issue 21039: Revert my change to get the tree green. Not sure why the tests became flaky....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/resource_dispatcher_unittest.cc

Issue 21039: Revert my change to get the tree green. Not sure why the tests became flaky.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: Created 11 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/common/resource_dispatcher_unittest.cc

===================================================================

--- chrome/common/resource_dispatcher_unittest.cc (revision 9131)

+++ chrome/common/resource_dispatcher_unittest.cc (working copy)

@@ -84,10 +84,10 @@

void* iter = NULL;

int request_id;

- ASSERT_TRUE(ReadParam(&message_queue_[0], &iter, &request_id));

+ ASSERT_TRUE(IPC::ReadParam(&message_queue_[0], &iter, &request_id));

ViewHostMsg_Resource_Request request;

- ASSERT_TRUE(ReadParam(&message_queue_[0], &iter, &request));

+ ASSERT_TRUE(IPC::ReadParam(&message_queue_[0], &iter, &request));

// check values

EXPECT_EQ(test_page_url, request.url.spec());

@@ -119,7 +119,7 @@

// read the ack message.

iter = NULL;

int request_ack = -1;

- ASSERT_TRUE(ReadParam(&message_queue_[0], &iter, &request_ack));

+ ASSERT_TRUE(IPC::ReadParam(&message_queue_[0], &iter, &request_ack));

ASSERT_EQ(request_ack, request_id);

« no previous file with comments | « chrome/common/resource_bundle.h ('k') | chrome/common/security_filter_peer.h » ('j') | no next file with comments »