Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2103005: Add script to collect logs, dumps and other relevant information. (Closed)

Created:
10 years, 7 months ago by ruchic
Modified:
9 years, 7 months ago
Reviewers:
petkov, sosa
CC:
chromium-os-reviews_chromium.org, Luigi Semenzato, sosa, rchenna, krisr, petkov
Base URL:
http://src.chromium.org/git/chromium.git
Visibility:
Public.

Description

Add script to collect logs, dumps and other relevant information.

Patch Set 1 #

Total comments: 27

Patch Set 2 : Changes to generate_logs as per review comments #

Patch Set 3 : Changes to generate_logs to remove - from echo statements #

Total comments: 17

Patch Set 4 : Changes round 2 to script generate_logs as per review comments #

Patch Set 5 : Changes to remove Wifi adapter info #

Total comments: 18

Patch Set 6 : Changes to generate_logs for optimization #

Patch Set 7 : Changes to generate_logs script for optimization #

Total comments: 5

Patch Set 8 : More changes for optimization #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
A src/platform/metrics/generate_logs View 1 2 3 4 5 6 7 1 chunk +82 lines, -0 lines 1 comment Download

Messages

Total messages: 20 (0 generated)
ruchic
10 years, 7 months ago (2010-05-17 21:14:09 UTC) #1
sosa
http://codereview.chromium.org/2103005/diff/1/2 File src/platform/metrics/generate_logs (right): http://codereview.chromium.org/2103005/diff/1/2#newcode9 src/platform/metrics/generate_logs:9: One one line needed http://codereview.chromium.org/2103005/diff/1/2#newcode11 src/platform/metrics/generate_logs:11: if [ ! ...
10 years, 7 months ago (2010-05-17 22:14:08 UTC) #2
ruchic
Please see the changes made to the script and let me know of the corrections ...
10 years, 7 months ago (2010-05-21 17:07:22 UTC) #3
petkov
A few random nits... http://codereview.chromium.org/2103005/diff/8001/9001 File src/platform/metrics/generate_logs (right): http://codereview.chromium.org/2103005/diff/8001/9001#newcode10 src/platform/metrics/generate_logs:10: if [ ! -z $1 ...
10 years, 7 months ago (2010-05-21 18:05:35 UTC) #4
sosa
http://codereview.chromium.org/2103005/diff/8001/9001 File src/platform/metrics/generate_logs (right): http://codereview.chromium.org/2103005/diff/8001/9001#newcode10 src/platform/metrics/generate_logs:10: if [ ! -z $1 ] && ([ $1 ...
10 years, 7 months ago (2010-05-24 20:12:22 UTC) #5
sosa
10 years, 7 months ago (2010-05-24 20:12:30 UTC) #6
petkov
http://codereview.chromium.org/2103005/diff/8001/9001 File src/platform/metrics/generate_logs (right): http://codereview.chromium.org/2103005/diff/8001/9001#newcode10 src/platform/metrics/generate_logs:10: if [ ! -z $1 ] && ([ $1 ...
10 years, 7 months ago (2010-05-24 20:39:28 UTC) #7
ruchic
Please see the changes made to the script. Thanks, Ruchi http://codereview.chromium.org/2103005/diff/8001/9001 File src/platform/metrics/generate_logs (right): http://codereview.chromium.org/2103005/diff/8001/9001#newcode10 ...
10 years, 7 months ago (2010-05-25 22:24:39 UTC) #8
sosa
cpl nits from me, o/w lgtm from me. but hold off till petkov lgtm's as ...
10 years, 7 months ago (2010-05-26 01:16:47 UTC) #9
ruchic
On 2010/05/26 01:16:47, sosa wrote: > cpl nits from me, o/w lgtm from me. but ...
10 years, 7 months ago (2010-05-26 04:38:40 UTC) #10
sosa
No only multiletter options are --. -h an -? are one - because they are ...
10 years, 7 months ago (2010-05-26 04:44:55 UTC) #11
petkov
Again, just nits. It's just the script looks a bit too long and verbose for ...
10 years, 7 months ago (2010-05-26 05:05:02 UTC) #12
ruchic
Please see the changes made to the script. Thanks, Ruchi http://codereview.chromium.org/2103005/diff/19001/20001 File src/platform/metrics/generate_logs (right): http://codereview.chromium.org/2103005/diff/19001/20001#newcode10 ...
10 years, 7 months ago (2010-05-26 22:48:37 UTC) #13
petkov
LGTM with a couple of nits. Please address at least the first one before pushing. ...
10 years, 7 months ago (2010-05-27 04:22:07 UTC) #14
sosa
http://codereview.chromium.org/2103005/diff/30001/31001 File src/platform/metrics/generate_logs (right): http://codereview.chromium.org/2103005/diff/30001/31001#newcode37 src/platform/metrics/generate_logs:37: cp -r /var/log/messages \ In principal I agree with ...
10 years, 7 months ago (2010-05-27 17:02:03 UTC) #15
sosa
1: I've already removed xterm from base images so this isn't a concern. 2: Check ...
10 years, 7 months ago (2010-05-27 17:48:14 UTC) #16
ruchic
Thanks Chris and Darin for insightful comments. Regards, Ruchi http://codereview.chromium.org/2103005/diff/30001/31001 File src/platform/metrics/generate_logs (right): http://codereview.chromium.org/2103005/diff/30001/31001#newcode23 src/platform/metrics/generate_logs:23: ...
10 years, 7 months ago (2010-05-27 18:26:32 UTC) #17
sosa
still LGTM http://codereview.chromium.org/2103005/diff/30001/31001 File src/platform/metrics/generate_logs (right): http://codereview.chromium.org/2103005/diff/30001/31001#newcode37 src/platform/metrics/generate_logs:37: cp -r /var/log/messages \ Petkov actually corrected ...
10 years, 7 months ago (2010-05-27 19:51:24 UTC) #18
ruchic
Chris can you please commit the CL. Thanks, Ruchi
10 years, 7 months ago (2010-05-27 21:15:34 UTC) #19
sosa
10 years, 7 months ago (2010-05-27 21:18:11 UTC) #20

Powered by Google App Engine
This is Rietveld 408576698