Fix the dependency checker tool. Rules for a directory did modify their direc...

Fix the dependency checker tool. Rules for a directory did modify their directory parent rules. Using copy.copy() solves the problem.Additional fix when "allow-current-directory" rules was not applied if DEPS file is missing.

Updated few DEPS file with reasonable rules.
To prevent tree closing other dependencies are added. These need to be either legitimated or dependency removed.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=9221

[M-A Ruel, 2009-02-03 22:33:15]

lgtm

[stoyan, 2009-02-04 00:32:47]

Updated CL and the description. Please take another look.

[M-A Ruel, 2009-02-04 00:45:31]

http://codereview.chromium.org/21025/diff/1002/1008
File chrome/renderer/DEPS (right):

http://codereview.chromium.org/21025/diff/1002/1008#newcode5
Line 5: "+webkit/port",  # For certain drawing, would be nice to not have.
Is this one still needed?

[M-A Ruel, 2009-02-04 17:06:16]

I only have one comment and I'm fine with the rest. Waiting for Brett's approval
before checking-in.

http://codereview.chromium.org/21025/diff/21/1054
File webkit/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1054#newcode14
Line 14: "+third_party",
I'd prefer you to enumerate the dependencies there.

[brettw, 2009-02-04 17:13:45]

I commented on all the TODOs about what you should do. Thanks for fixing all
these.

LGTM with the comments fixed.

http://codereview.chromium.org/21025/diff/21/1049
File chrome/browser/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1049#newcode25
Line 25: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
Both of these are OK.

http://codereview.chromium.org/21025/diff/21/1051
File chrome/common/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1051#newcode12
Line 12: "+webkit/glue",
chrome/* is bad, everything else is OK.

http://codereview.chromium.org/21025/diff/21/1059
File chrome/installer/setup/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1059#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
This should be OK.

http://codereview.chromium.org/21025/diff/21/1060
File chrome/plugin/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1060#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
These are OK.

http://codereview.chromium.org/21025/diff/21/1053
File chrome/renderer/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1053#newcode6
Line 6: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
These are OK except for chrome/app/theme, chrome/browser/net, and chrome/views.

http://codereview.chromium.org/21025/diff/21/1053#newcode9
Line 9: "+chrome/app",
Can you add a comment to this one: "The plugins use the theme library to get the
sad plugin bitmap."

http://codereview.chromium.org/21025/diff/21/1058
File chrome/test/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1058#newcode5
Line 5: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
These are fine.

http://codereview.chromium.org/21025/diff/21/1062
File chrome/third_party/hunspell/google/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1062#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
This is fine.

http://codereview.chromium.org/21025/diff/21/1061
File chrome/tools/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1061#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
These are fine.

http://codereview.chromium.org/21025/diff/21/1052
File chrome/views/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1052#newcode5
Line 5: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
These are fine.

http://codereview.chromium.org/21025/diff/21/1057
File net/base/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1057#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
These are fine.

http://codereview.chromium.org/21025/diff/21/1055
File webkit/glue/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1055#newcode8
Line 8: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
skia/* is OK, chrome/* is not.

http://codereview.chromium.org/21025/diff/21/1056
File webkit/tools/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1056#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
These are fine.

[stoyan, 2009-02-04 17:47:54]

Brett please take a look at webkit/DEPS. I enumerated the dependencies there as
Marc-Antoine asked.

http://codereview.chromium.org/21025/diff/21/1049
File chrome/browser/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1049#newcode25
Line 25: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
On 2009/02/04 17:13:45, brettw wrote:
> Both of these are OK.

Done.

http://codereview.chromium.org/21025/diff/21/1051
File chrome/common/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1051#newcode12
Line 12: "+webkit/glue",
On 2009/02/04 17:13:45, brettw wrote:
> chrome/* is bad, everything else is OK.

Done.

http://codereview.chromium.org/21025/diff/21/1059
File chrome/installer/setup/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1059#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
On 2009/02/04 17:13:45, brettw wrote:
> This should be OK.

Done.

http://codereview.chromium.org/21025/diff/21/1060
File chrome/plugin/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1060#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
On 2009/02/04 17:13:45, brettw wrote:
> These are OK.

Done.

http://codereview.chromium.org/21025/diff/21/1053
File chrome/renderer/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1053#newcode6
Line 6: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
On 2009/02/04 17:13:45, brettw wrote:
> These are OK except for chrome/app/theme, chrome/browser/net, and
chrome/views.

Done.

http://codereview.chromium.org/21025/diff/21/1053#newcode9
Line 9: "+chrome/app",
On 2009/02/04 17:13:45, brettw wrote:
> Can you add a comment to this one: "The plugins use the theme library to get
the
> sad plugin bitmap."

Done.

http://codereview.chromium.org/21025/diff/21/1058
File chrome/test/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1058#newcode5
Line 5: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
On 2009/02/04 17:13:45, brettw wrote:
> These are fine.

Done.

http://codereview.chromium.org/21025/diff/21/1062
File chrome/third_party/hunspell/google/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1062#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
On 2009/02/04 17:13:45, brettw wrote:
> This is fine.

Done.

http://codereview.chromium.org/21025/diff/21/1061
File chrome/tools/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1061#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
On 2009/02/04 17:13:45, brettw wrote:
> These are fine.

Done.

http://codereview.chromium.org/21025/diff/21/1052
File chrome/views/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1052#newcode5
Line 5: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
On 2009/02/04 17:13:45, brettw wrote:
> These are fine.

Done.

http://codereview.chromium.org/21025/diff/21/1057
File net/base/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1057#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
On 2009/02/04 17:13:45, brettw wrote:
> These are fine.

Done.

http://codereview.chromium.org/21025/diff/21/1054
File webkit/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1054#newcode14
Line 14: "+third_party",
On 2009/02/04 17:06:16, M-A wrote:
> I'd prefer you to enumerate the dependencies there.

Done.

http://codereview.chromium.org/21025/diff/21/1055
File webkit/glue/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1055#newcode8
Line 8: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
On 2009/02/04 17:13:45, brettw wrote:
> skia/* is OK, chrome/* is not.

Done.

http://codereview.chromium.org/21025/diff/21/1056
File webkit/tools/DEPS (right):

http://codereview.chromium.org/21025/diff/21/1056#newcode3
Line 3: # TODO(brettw) - review these; move up if it's ok, or remove the
dependency
On 2009/02/04 17:13:45, brettw wrote:
> These are fine.

Done.

[brettw, 2009-02-04 17:58:05]

LGTM. I don't know about the net includes, so it's OK to just leave the TODO.