Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1656)

Unified Diff: chrome/browser/views/options/general_page_view.h

Issue 2102019: Invalid URLs are no longer mangled when reopening the Options window (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/gtk/options/general_page_gtk.cc ('k') | chrome/browser/views/options/general_page_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/options/general_page_view.h
===================================================================
--- chrome/browser/views/options/general_page_view.h (revision 47986)
+++ chrome/browser/views/options/general_page_view.h (working copy)
@@ -1,4 +1,4 @@
-// Copyright (c) 2009 The Chromium Authors. All rights reserved.
+// Copyright (c) 2010 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -105,10 +105,9 @@
const GURL& url);
// Sets the home page preferences for kNewTabPageIsHomePage and kHomePage.
- // If a blank string is passed in we revert to using NewTab page as the Home
- // page. When setting the Home Page to NewTab page, we preserve the old value
- // of kHomePage (we don't overwrite it).
- void SetHomepage(const std::wstring& homepage);
+ // If an empty or null-host GURL is passed in we revert to using NewTab
+ // page as the Homepage.
+ void SetHomepage(const GURL& homepage);
// Invoked when the selection of the table view changes. Updates the enabled
// property of the remove button.
« no previous file with comments | « chrome/browser/gtk/options/general_page_gtk.cc ('k') | chrome/browser/views/options/general_page_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698