Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Side by Side Diff: chrome/browser/gtk/options/general_page_gtk.cc

Issue 2102019: Invalid URLs are no longer mangled when reopening the Options window (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/gtk/options/general_page_gtk.h" 5 #include "chrome/browser/gtk/options/general_page_gtk.h"
6 6
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "app/l10n_util.h" 10 #include "app/l10n_util.h"
(...skipping 610 matching lines...) Expand 10 before | Expand all | Expand 10 after
621 NOTREACHED(); 621 NOTREACHED();
622 } 622 }
623 623
624 void GeneralPageGtk::EnableDefaultSearchEngineComboBox(bool enable) { 624 void GeneralPageGtk::EnableDefaultSearchEngineComboBox(bool enable) {
625 gtk_widget_set_sensitive(default_search_engine_combobox_, enable); 625 gtk_widget_set_sensitive(default_search_engine_combobox_, enable);
626 } 626 }
627 627
628 void GeneralPageGtk::SetHomepage(const GURL& homepage) { 628 void GeneralPageGtk::SetHomepage(const GURL& homepage) {
629 if (!homepage.is_valid() || homepage.spec() == chrome::kChromeUINewTabURL) { 629 if (!homepage.is_valid() || homepage.spec() == chrome::kChromeUINewTabURL) {
630 new_tab_page_is_home_page_.SetValue(true); 630 new_tab_page_is_home_page_.SetValue(true);
631 if (!homepage.has_host())
632 homepage_.SetValue(std::wstring());
631 } else { 633 } else {
632 new_tab_page_is_home_page_.SetValue(false); 634 new_tab_page_is_home_page_.SetValue(false);
633 homepage_.SetValue(UTF8ToWide(homepage.spec())); 635 homepage_.SetValue(UTF8ToWide(homepage.spec()));
634 } 636 }
635 } 637 }
636 638
637 void GeneralPageGtk::SetHomepageFromEntry() { 639 void GeneralPageGtk::SetHomepageFromEntry() {
638 GURL url(URLFixerUpper::FixupURL( 640 GURL url(URLFixerUpper::FixupURL(
639 gtk_entry_get_text(GTK_ENTRY(homepage_use_url_entry_)), "")); 641 gtk_entry_get_text(GTK_ENTRY(homepage_use_url_entry_)), ""));
640 SetHomepage(url); 642 SetHomepage(url);
(...skipping 28 matching lines...) Expand all
669 if (color) { 671 if (color) {
670 char* markup = g_markup_printf_escaped(kDefaultBrowserLabelMarkup, 672 char* markup = g_markup_printf_escaped(kDefaultBrowserLabelMarkup,
671 color, text.c_str()); 673 color, text.c_str());
672 gtk_label_set_markup(GTK_LABEL(default_browser_status_label_), markup); 674 gtk_label_set_markup(GTK_LABEL(default_browser_status_label_), markup);
673 g_free(markup); 675 g_free(markup);
674 } 676 }
675 677
676 gtk_widget_set_sensitive(default_browser_use_as_default_button_, 678 gtk_widget_set_sensitive(default_browser_use_as_default_button_,
677 state == ShellIntegration::STATE_NOT_DEFAULT); 679 state == ShellIntegration::STATE_NOT_DEFAULT);
678 } 680 }
OLDNEW
« no previous file with comments | « chrome/browser/gtk/options/general_page_gtk.h ('k') | chrome/browser/views/options/general_page_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698