Issue 2102010: Addressing review comment from Stoyan (remove one dlog statement)....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2102010: Addressing review comment from Stoyan (remove one dlog statement).... (Closed)

Created:
10 years, 7 months ago by tommi (sloooow) - chröme

Modified:
9 years, 7 months ago

Reviewers:
stoyan

CC:
chromium-reviews, amit

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Addressing review comment from Stoyan (remove one dlog statement). TEST=none BUG=none TBR=stoyan Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47691

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -3 lines)			Patch
	M	chrome_frame/bind_context_info.cc	View		1 chunk	+0 lines, -3 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

stoyan

10 years, 7 months ago (2010-05-19 18:54:49 UTC) #2

http://codereview.chromium.org/2102010/diff/1/2
File chrome_frame/bind_context_info.cc (right):

http://codereview.chromium.org/2102010/diff/1/2#newcode50
chrome_frame/bind_context_info.cc:50: BindContextInfo* ret = NULL;
Well, now ret variable is unused.
I though the DLOG could be DLOG_IF(info != internal) if we want to preserve it
for debugging.

Expand Messages | Collapse Messages