Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Unified Diff: base/win_util.h

Issue 21018: Adding tracking of HWND creation/destruction (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/win_util.cc » ('j') | base/win_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win_util.h
===================================================================
--- base/win_util.h (revision 9063)
+++ base/win_util.h (working copy)
@@ -10,6 +10,8 @@
#include <string>
+#include "base/tracked.h"
+
namespace win_util {
// NOTE: Keep these in order so callers can do things like
@@ -102,6 +104,22 @@
// Uses the last Win32 error to generate a human readable message string.
std::wstring FormatLastWin32Error();
+// These 2 methods are used to track HWND creation/destruction to investigate
+// a mysterious crasher http://crbugs.com/4714 (crasher in on NCDestroy) that
+// might be caused by a multiple delete of an HWND.
+void NotifyHWNDCreation(const tracked_objects::Location& from_here, HWND hwnd);
+void NotifyHWNDDestruction(const tracked_objects::Location& from_here,
+ HWND hwnd);
+
+#ifdef NDEBUG
+#define TRACK_HWND_CREATION(hwnd)
+#define TRACK_HWND_DESTRUCTION(hwnd)
+#else
+#define TRACK_HWND_CREATION(hwnd) win_util::NotifyHWNDCreation(FROM_HERE, hwnd)
+#define TRACK_HWND_DESTRUCTION(hwnd) \
+ win_util::NotifyHWNDDestruction(FROM_HERE, hwnd)
+#endif
+
} // namespace win_util
#endif // BASE_WIN_UTIL_H__
« no previous file with comments | « no previous file | base/win_util.cc » ('j') | base/win_util.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698