Adding tracking of HWND creation/destruction

base/win_util.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/win_util.h"
 
+#include <map>
 #include <sddl.h>
 
 #include "base/logging.h"
 #include "base/registry.h"
 #include "base/scoped_handle.h"
+#include "base/singleton.h"
 #include "base/string_util.h"
+#include "base/tracked.h"
 
 namespace win_util {
 
 #define SIZEOF_STRUCT_WITH_SPECIFIED_LAST_MEMBER(struct_name, member) \
     offsetof(struct_name, member) + \
     (sizeof static_cast<struct_name*>(NULL)->member)
 #define NONCLIENTMETRICS_SIZE_PRE_VISTA \
     SIZEOF_STRUCT_WITH_SPECIFIED_LAST_MEMBER(NONCLIENTMETRICS, lfMessageFont)
 
 void GetNonClientMetrics(NONCLIENTMETRICS* metrics) {
@@ skipping 331 matching lines @@
     // The formating failed. simply convert the message value into a string.
     SStringPrintf(&formatted_string, L"message number %d", messageid);
   }
   return formatted_string;
 }
 
 std::wstring FormatLastWin32Error() {
   return FormatMessage(GetLastError());
 }
 
+typedef std::map<HWND, tracked_objects::Location> HWNDInfoMap;
+struct HWNDBirthMapTrait : public DefaultSingletonTraits<HWNDInfoMap> {
+};
+struct HWNDDeathMapTrait : public DefaultSingletonTraits<HWNDInfoMap> {
+};
+
+void NotifyHWNDCreation(const tracked_objects::Location& from_here, HWND hwnd) {
+  HWNDInfoMap* birth_map = Singleton<HWNDInfoMap, HWNDBirthMapTrait>::get();
+  HWNDInfoMap::iterator birth_iter = birth_map->find(hwnd);
+  if (birth_iter != birth_map->end()) {
+    birth_map->erase(birth_iter);
+
+    // We have already seen this HWND, was it destroyed?
+    HWNDInfoMap* death_map = Singleton<HWNDInfoMap, HWNDDeathMapTrait>::get();
+    HWNDInfoMap::iterator death_iter = death_map->find(hwnd);
+    if (death_iter == death_map->end()) {
+      // We did not get a destruction notification.  The code is probably not
+      // calling NotifyHWNDDestruction for that HWND.
+      NOTREACHED() << "Creation of HWND reported for already tracked HWND. The "
+                      "HWND destruction is probably not tracked properly. "
+                      "Fix it!";
+    } else {
+      death_map->erase(death_iter);
+    }
+  }
+  birth_map->insert(std::pair<HWND, tracked_objects::Location>(hwnd,
+                                                              from_here));
+}
+
+void NotifyHWNDDestruction(const tracked_objects::Location& from_here,
+                           HWND hwnd) {
+  HWNDInfoMap* death_map = Singleton<HWNDInfoMap, HWNDDeathMapTrait>::get();
+  HWNDInfoMap::iterator death_iter = death_map->find(hwnd);
+
+  HWNDInfoMap* birth_map = Singleton<HWNDInfoMap, HWNDBirthMapTrait>::get();
+  HWNDInfoMap::iterator birth_iter = birth_map->find(hwnd);
+
+  if (death_iter != death_map->end()) {
+    std::string allocation, first_delete, second_delete;
+    if (birth_iter != birth_map->end())
+      birth_iter->second.Write(true, true, &allocation);
+    death_iter->second.Write(true, true, &first_delete);
+    from_here.Write(true, true, &second_delete);
+    NOTREACHED() << "Double delete of an HWND. Please file a bug with info on "
+        "how you got that assertion and the following information:\n"
+        "Double delete of HWND 0x" << hwnd << "\n" <<

[sky, 2009/02/03 20:37:24]

will "<< hwnd" give you hex, or decimal?

+        "Allocated at " << allocation << "\n" <<
+        "Deleted first at " << first_delete << "\n" <<
+        "Deleted again at " << second_delete;
+    death_map->erase(death_iter);
+  }
+
+  if (birth_iter == birth_map->end()) {
+    NOTREACHED() << "Destruction of HWND reported for unknown HWND. The HWND "
+                    "construction is probably not tracked properly. Fix it!";
+  }
+  death_map->insert(std::pair<HWND, tracked_objects::Location>(hwnd,
+                                                               from_here));
+}
+
 }  // namespace win_util
 
 #ifdef _MSC_VER
 //
 // If the ASSERT below fails, please install Visual Studio 2005 Service Pack 1.
 //
 extern char VisualStudio2005ServicePack1Detection[10];
 COMPILE_ASSERT(sizeof(&VisualStudio2005ServicePack1Detection) == sizeof(void*),
                VS2005SP1Detect);
 //
 // Chrome requires at least Service Pack 1 for Visual Studio 2005.
 //
 #endif  // _MSC_VER
 
 #ifndef COPY_FILE_COPY_SYMLINK
 #error You must install the Windows 2008 or Vista Software Development Kit and \
 set it as your default include path to build this library. You can grab it by \
 searching for "download windows sdk 2008" in your favorite web search engine.  \
 Also make sure you register the SDK with Visual Studio, by selecting \
 "Integrate Windows SDK with Visual Studio 2005" from the Windows SDK \
 menu (see Start - All Programs - Microsoft Windows SDK - \
 Visual Studio Registration).
 #endif