media/filters/audio_renderer_base.h - Issue 2101022: refactoring decoder interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/filters/audio_renderer_base.h

Issue 2101022: refactoring decoder interface (Closed)

Patch Set: q Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/filters/audio_renderer_base.h

diff --git a/media/filters/audio_renderer_base.h b/media/filters/audio_renderer_base.h

index 3b3b59343d4ce337442ec11b1f78e2cd81ffb317..37626792b2849c3762ec08b2f230343982edab0f 100644

--- a/media/filters/audio_renderer_base.h

+++ b/media/filters/audio_renderer_base.h

@@ -55,9 +55,9 @@ class AudioRendererBase : public AudioRenderer {

// this time, such as stopping any running threads.

virtual void OnStop() = 0;

- // Called when a AudioDecoder::Read() completes and decrements

+ // Called when a AudioDecoder completes decoding and decrements

// |pending_reads_|.

- virtual void OnReadComplete(Buffer* buffer_in);

+ virtual void OnFillBufferDone(scoped_refptr<Buffer> buffer_in);

// Fills the given buffer with audio data by delegating to its |algorithm_|.

// FillBuffer() also takes care of updating the clock. Returns the number of

« no previous file with comments | « media/base/mock_filters.h ('k') | media/filters/audio_renderer_base.cc » ('j') | no next file with comments »