Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2101019: Print Preview component extension (Closed)

Created:
10 years, 7 months ago by feldstein
Modified:
6 years, 9 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), pam+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Beginnings of the print preview component extension. Uses mock data currently until I can hook it up to the backend. BUG=NONE TEST=NONE

Patch Set 1 #

Patch Set 2 : Change host from printpreview to print #

Patch Set 3 : Add some options #

Patch Set 4 : Add Options box and clean up #

Total comments: 1

Patch Set 5 : Start html from scratch.. looks much better #

Patch Set 6 : Mostly Working #

Patch Set 7 : Add RTL Support #

Patch Set 8 : Put it under a flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+906 lines, -12 lines) Patch
M chrome/browser/browser_resources.grd View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/dom_ui/shared_resources_data_source.cc View 7 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -1 line 0 comments Download
A chrome/browser/resources/print_preview/js/preview_list.js View 1 2 3 4 1 chunk +124 lines, -0 lines 0 comments Download
A chrome/browser/resources/print_preview/manifest.json View 1 Binary file 0 comments Download
A chrome/browser/resources/print_preview/page.png View Binary file 0 comments Download
A chrome/browser/resources/print_preview/page2.png View Binary file 0 comments Download
A chrome/browser/resources/print_preview/print_preview.css View 1 2 3 4 5 6 7 1 chunk +139 lines, -0 lines 0 comments Download
A chrome/browser/resources/print_preview/print_preview.html View 1 2 3 4 5 6 7 1 chunk +228 lines, -0 lines 0 comments Download
M chrome/browser/resources/shared/css/button.css View 1 2 3 4 6 1 chunk +26 lines, -1 line 0 comments Download
A chrome/browser/resources/shared/css/chrome.css View 1 2 3 1 chunk +286 lines, -0 lines 0 comments Download
A chrome/browser/resources/shared/css/radiobuttons.css View 1 chunk +8 lines, -0 lines 0 comments Download
A chrome/browser/resources/shared/images/dropdown_arrow.png View Binary file 0 comments Download
M chrome/browser/resources/shared/js/cr/ui/menu_item.js View 6 7 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/resources/shared_resources.grd View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 1 chunk +63 lines, -0 lines 0 comments Download
M chrome/chrome_dll.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_paths.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
chrome/common/chrome_paths.cc View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.cc View 1 2 3 4 5 6 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/url_constants.cc View 1 2 3 4 5 6 2 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
viettrungluu
10 years, 7 months ago (2010-05-27 18:13:58 UTC) #1 
http://codereview.chromium.org/2101019/diff/13001/14013
File chrome/chrome_browser.gypi (right):

http://codereview.chromium.org/2101019/diff/13001/14013#newcode3296
chrome/chrome_browser.gypi:3296: 'browser/resources/shared/css/textfields.css',
Hey Mike, did you forget to git-add this file?

Powered by Google App Engine
This is Rietveld 408576698