webkit/glue/webmediaplayer_impl.cc - Issue 2101015: Change MediaFilter::Stop() to accept a callback so that Stop() is asynchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/webmediaplayer_impl.cc

Issue 2101015: Change MediaFilter::Stop() to accept a callback so that Stop() is asynchronous. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Revert filter changes. Going to make that another patch. Created 10 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/webmediaplayer_impl.cc

diff --git a/webkit/glue/webmediaplayer_impl.cc b/webkit/glue/webmediaplayer_impl.cc

index 0157c80c2709c1fcf2f07388714f2d0175472a11..66cf896a2ab05320b2a547a1995ae12d2ba2e78d 100644

--- a/webkit/glue/webmediaplayer_impl.cc

+++ b/webkit/glue/webmediaplayer_impl.cc

@@ -634,10 +634,6 @@ void WebMediaPlayerImpl::OnPipelineError() {

DCHECK(MessageLoop::current() == main_loop_);

switch (pipeline_->GetError()) {

case media::PIPELINE_OK:

- case media::PIPELINE_STOPPING:

- NOTREACHED() << "We shouldn't get called with these non-errors";

- break;

case media::PIPELINE_ERROR_INITIALIZATION_FAILED:

case media::PIPELINE_ERROR_REQUIRED_FILTER_MISSING:

case media::PIPELINE_ERROR_COULD_NOT_RENDER:

« media/base/pipeline_impl.cc ('K') | « media/base/pipeline_impl_unittest.cc ('k') | no next file » | no next file with comments »