Issue 210040: Prepare to push to trunk. Now working on 1.3.13.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210040: Prepare to push to trunk. Now working on 1.3.13. (Closed)

Created:
11 years, 3 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Prepare to push to trunk. Now working on 1.3.13. Committed: http://code.google.com/p/v8/source/detail?r=2947

Patch Set 1 #

Total comments: 1

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	ChangeLog	View		1 chunk	+15 lines, -0 lines	1 comment	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 3 months ago (2009-09-22 08:35:45 UTC) #2

LGTM

http://codereview.chromium.org/210040/diff/1/3
File ChangeLog (right):

http://codereview.chromium.org/210040/diff/1/3#newcode4
Line 4: other implementations.  Patch by Jan de Mooij.
Maybe mention that this only changes toString on builtin functions.

Expand Messages | Collapse Messages