Issue 210036: Make it possible to edit bookmark folder names inline. This

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210036: Make it possible to edit bookmark folder names inline. This (Closed)

Created:
11 years, 3 months ago by tony

Modified:
9 years, 7 months ago

Reviewers:
mattm, Evan Stade

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Make it possible to edit bookmark folder names inline. This works in both the edit bookmark dialog and in the bookmark manager. BUG=20328 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26828

Patch Set 1 #

Patch Set 2 : bookmark manager #

Total comments: 3

Patch Set 3 : comments #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -13 lines)			Patch
M	chrome/browser/gtk/bookmark_editor_gtk.cc	View	1	2 chunks	+9 lines, -4 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.h	View	2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_manager_gtk.cc	View	2	4 chunks	+21 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_tree_model.h	View	1	3 chunks	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/bookmark_tree_model.cc	View	1 2	4 chunks	+34 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

lgtm, but could you put a couple comments explaining the function of the callbacks (i.e. ...

11 years, 3 months ago (2009-09-22 00:30:08 UTC) #2

mattm

11 years, 3 months ago (2009-09-22 00:32:53 UTC) #3

nits:

typo in BUG number?

http://codereview.chromium.org/210036/diff/2001/3003
File chrome/browser/gtk/bookmark_manager_gtk.h (right):

http://codereview.chromium.org/210036/diff/2001/3003#newcode286
Line 286: reinterpret_cast<BookmarkManagerGtk*>(self)->
unnecessary cast

Expand Messages | Collapse Messages