Issue 210035: Makes tab dragging on views restrict the drag to the main window....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210035: Makes tab dragging on views restrict the drag to the main window.... (Closed)

Created:
11 years, 3 months ago by sky

Modified:
9 years, 7 months ago

Reviewers:
jcampan

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Makes tab dragging on views restrict the drag to the main window. As X is async, this results in annoying flicker right now. If we stick with this we're going to need to avoid creating a new window. But this is good enough for now. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26820

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -18 lines)			Patch
	M	chrome/browser/views/tabs/dragged_tab_controller.cc	View		3 chunks	+15 lines, -1 line	0 comments	Download
	M	chrome/browser/views/tabs/dragged_tab_view.cc	View		8 chunks	+20 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages