Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: net/proxy/proxy_resolver.h

Issue 210028: Respect the charset specified in PAC file responses. ProxyScriptFetcher is no... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: re-order parameter so output is last Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/data/proxy_script_fetcher_unittest/utf16be_pac.mock-http-headers ('k') | net/proxy/proxy_resolver_v8.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/proxy_resolver.h
===================================================================
--- net/proxy/proxy_resolver.h (revision 26789)
+++ net/proxy/proxy_resolver.h (working copy)
@@ -59,10 +59,10 @@
}
// Sets the PAC script backend to use for this proxy resolver (by contents).
- int SetPacScriptByData(const std::string& bytes,
+ int SetPacScriptByData(const std::string& bytes_utf8,
CompletionCallback* callback) {
DCHECK(expects_pac_bytes());
- return SetPacScript(GURL(), bytes, callback);
+ return SetPacScript(GURL(), bytes_utf8, callback);
}
// TODO(eroman): Make this =0.
@@ -72,12 +72,12 @@
private:
// Called to set the PAC script backend to use. If |pac_url| is invalid,
- // this is a request to use WPAD (auto detect). |bytes| may be empty if the
- // fetch failed, or if the fetch returned no content.
+ // this is a request to use WPAD (auto detect). |bytes_utf8| may be empty if
+ // the fetch failed, or if the fetch returned no content.
// Returns ERR_IO_PENDING in the case of asynchronous completion, and notifies
// the result through |callback|.
virtual int SetPacScript(const GURL& pac_url,
- const std::string& bytes,
+ const std::string& bytes_utf8,
CompletionCallback* callback) = 0;
const bool expects_pac_bytes_;
« no previous file with comments | « net/data/proxy_script_fetcher_unittest/utf16be_pac.mock-http-headers ('k') | net/proxy/proxy_resolver_v8.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698