Adding a GYP variable to indicate if a build wants Title Case strings or not....

Adding a GYP variable to indicate if a build wants Title Case strings or not.
Default to Title Case strings for Mac and Linux/GTK.
Pass an extra define to the invoke of grit for TitleCase strings.
Test the define for grit Title Case strings and have two sets of strings where needed.
DEPs roll to pick up a new GYP that will keep int values as ints.

BUG=22253
TEST=The bookmark bar menus on Mac and linux gtk will be Title Case, in Windows and ChromeOS they will be Sentence case.  NOTE: we'll the translations in the Title Case areas until new translations are entered.

committed as r26803

[TVL, 2009-09-18 17:38:58]

Tony - For GRD directives/etc.
Mark - GYP changes and because he always finds all my typos/forgotten things.

[tony, 2009-09-18 17:48:06]

LGTM, thanks for making the descriptions clear.

[TVL, 2009-09-18 17:50:55]

the linux try bot doesn't like this cl.  it it's throwing an error when evaling
the conditional for either chromeos or toolkit_views, but i'm not seeing why.

[TVL, 2009-09-18 17:55:41]

On 2009/09/18 17:50:55, TVL wrote:
> the linux try bot doesn't like this cl.  it it's throwing an error when
evaling
> the conditional for either chromeos or toolkit_views, but i'm not seeing why.

sending new version to the try bots to see if it helps

[Mark Mentovai, 2009-09-18 18:02:31]

LGTM.  Consider this:

Another option would be to have grit_extra_flags that we can either define to be
[] or ['-D', 'your_define'].  Then we can shorten the modificatons to the
existing grit rules to just add '<@(grit_extra_flags)' to the action lines that
are already there.

http://codereview.chromium.org/210022/diff/4001/4003
File build/common.gypi (right):

http://codereview.chromium.org/210022/diff/4001/4003#newcode47
Line 47: 'chromeos%': 0,
Quick comment on this bad boy?

[TVL, 2009-09-18 18:14:36]

On 2009/09/18 18:02:31, Mark Mentovai wrote:
> LGTM.  Consider this:
> 
> Another option would be to have grit_extra_flags that we can either define to
be
> [] or ['-D', 'your_define'].  Then we can shorten the modificatons to the
> existing grit rules to just add '<@(grit_extra_flags)' to the action lines
that
> are already there.

So the only catch is that can't really be overridden as easily, no?  or don't
worry about that at this point?  it does have the advantage it would help get
chromeos defined on all grit invokes if we added that in also.

> 
> http://codereview.chromium.org/210022/diff/4001/4003
> File build/common.gypi (right):
> 
> http://codereview.chromium.org/210022/diff/4001/4003#newcode47
> Line 47: 'chromeos%': 0,
> Quick comment on this bad boy?

[Mark Mentovai, 2009-09-18 18:14:48]

LGTM

I haven't read all of your messages.

http://codereview.chromium.org/210022/diff/2007/2009
File build/common.gypi (right):

http://codereview.chromium.org/210022/diff/2007/2009#newcode42
Line 42: # By default linux does not use views. To turn on views in Linux
By default, Linux does

(comma and capital L)

and

To turn on views in Linux,

(comma)

http://codereview.chromium.org/210022/diff/2007/2009#newcode47
Line 47: 'chromeos%': 0,
Still no comment on what chromeos% does?  Even if it's a simple one-liner?

[TVL, 2009-09-21 11:50:22]

Updated with DEPS roll to get a newer GYP to resolve the issue with ints being
converted to strings.

[Mark Mentovai, 2009-09-21 13:10:41]

lg

http://codereview.chromium.org/210022/diff/4008/8008
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/210022/diff/4008/8008#newcode4636
Line 4636: <message name="IDS_BOOKMARK_MANAGER" desc="In Title Case:The label of
the menu item that shows the bookmark manager">
colon space