Issue 210019: GTK: Add a bunch more widget names for parasite....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 210019: GTK: Add a bunch more widget names for parasite.... (Closed)

Created:
11 years, 3 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

GTK: Add a bunch more widget names for parasite. Also, change slightly how we apply custom styles to certain buttons. BUG=22096 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26623

Patch Set 1 #

Total comments: 3

Patch Set 2 : comments #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -6 lines)			Patch
M	chrome/browser/gtk/bookmark_bar_gtk.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/gtk/gtk_chrome_button.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/gtk/gtk_chrome_link_button.cc	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/browser/gtk/view_id_util.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/gtk/view_id_util.cc	View	1	2 chunks	+60 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Evan Stade

http://codereview.chromium.org/210019/diff/1/5 File chrome/browser/gtk/bookmark_bar_gtk.cc (left): http://codereview.chromium.org/210019/diff/1/5#oldcode597 Line 597: ViewIDUtil::SetID(widget, VIEW_ID_BOOKMARK_MENU); the VIEW_ID_BOOKMARK_MENU is actually supposed to ...

11 years, 3 months ago (2009-09-18 03:01:03 UTC) #1

Evan Martin

LGTM http://codereview.chromium.org/210019/diff/1/3 File chrome/browser/gtk/view_id_util.cc (right): http://codereview.chromium.org/210019/diff/1/3#newcode105 Line 105: // set its ID. Does this comment ...

11 years, 3 months ago (2009-09-18 05:24:41 UTC) #2

Evan Stade

11 years, 3 months ago (2009-09-18 17:47:04 UTC) #3

http://codereview.chromium.org/210019/diff/1/3
File chrome/browser/gtk/view_id_util.cc (right):

http://codereview.chromium.org/210019/diff/1/3#newcode105
Line 105: // set its ID.
On 2009/09/18 05:24:41, Evan Martin wrote:
> Does this comment refer to VIEW_ID_TAB_CONTAINER?
> In that case, shouldn't it go above the default: case?

yea, it could. I was thinking it could change at some point and be hit, but I'm
probably planning for an imaginary future.

Expand Messages | Collapse Messages