Issue 210013: Making BrowserFocusTest FocusTraversal faster

Issue 210013: Making BrowserFocusTest FocusTraversal faster (Closed)

Created:
11 years, 3 months ago by jcampan

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews_googlegroups.com, darin (slow to review), brettw, jam, Ben Goodger (Google), Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

This CL makes the browser focus tests faster by replacing some time-outs with notifications. BUG=22065 TEST=Run the interactive tests, especially BrowserFocusTest*FocusTraversal* These tests should run in few seconds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26597

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 7

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+135 lines, -42 lines)			Patch
M	chrome/browser/browser.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browser.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_focus_uitest.cc	View	1 2 3	10 chunks	+67 lines, -39 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host.cc	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_view_host_delegate.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host.cc	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents.cc	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/tab_contents_view_gtk.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1 2	3 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/common/render_messages_internal.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/render_widget.cc	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download
M	chrome/test/ui_test_utils.h	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	chrome/test/ui_test_utils.cc	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

11 years, 3 months ago (2009-09-17 23:00:28 UTC) #2

As long as you convert change to changed, LGTM.

http://codereview.chromium.org/210013/diff/2010/2013
File chrome/browser/browser_focus_uitest.cc (right):

http://codereview.chromium.org/210013/diff/2010/2013#newcode416
Line 416: // focus has change in the page.  The notification in the renderer may
change
nit: change -> changed

http://codereview.chromium.org/210013/diff/2010/2019
File chrome/browser/renderer_host/render_view_host.cc (right):

http://codereview.chromium.org/210013/diff/2010/2019#newcode1565
Line 1565: void RenderViewHost::OnMsgFocusedNodeChange() {
change -> changed

http://codereview.chromium.org/210013/diff/2010/2020
File chrome/browser/renderer_host/render_view_host.h (right):

http://codereview.chromium.org/210013/diff/2010/2020#newcode454
Line 454: virtual void OnMsgFocusedNodeChange();
change-> changed

http://codereview.chromium.org/210013/diff/2010/2021
File chrome/browser/renderer_host/render_widget_host.cc (right):

http://codereview.chromium.org/210013/diff/2010/2021#newcode135
Line 135: IPC_MESSAGE_HANDLER(ViewHostMsg_FocusedNodeChange,
OnMsgFocusedNodeChange)
change -> changed

http://codereview.chromium.org/210013/diff/2010/2024
File chrome/common/notification_type.h (right):

http://codereview.chromium.org/210013/diff/2010/2024#newcode410
Line 410: FOCUS_CHANGE_IN_PAGE,
change-> changed

http://codereview.chromium.org/210013/diff/2010/2023
File chrome/common/render_messages_internal.h (right):

http://codereview.chromium.org/210013/diff/2010/2023#newcode887
Line 887: IPC_MESSAGE_ROUTED0(ViewHostMsg_FocusedNodeChange)
changed

http://codereview.chromium.org/210013/diff/2010/2025
File chrome/renderer/render_widget.cc (right):

http://codereview.chromium.org/210013/diff/2010/2025#newcode657
Line 657: Send(new ViewHostMsg_FocusedNodeChange(routing_id_));
change -> changed

Expand Messages | Collapse Messages