Issue 2100012: Fix for bug 44624: Updating calls to AwaitMutualSyncCycleCompletion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2100012: Fix for bug 44624: Updating calls to AwaitMutualSyncCycleCompletion. (Closed)

Created:
10 years, 7 months ago by Raghu Simha

Modified:
9 years, 7 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Fix for bug 44624: Updating calls to AwaitMutualSyncCycleCompletion. The AutoFill integration tests were calling AwaitMutualSyncCycleCompletion() incorrectly in some cases. This patch fixes the calls based on which client made an update. The tests now pass with this fix. BUG=44624 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47978

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/test/live_sync/two_client_live_autofill_sync_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

10 years, 7 months ago (2010-05-21 18:36:17 UTC) #3

LGTM.

I think this is your first checkin as a provisional committer -- please use your
new access to run this on the trybots before committing.  After you commit, it's
your responsibility to watch the continuous builder to make sure that things
pass.  Otherwise the sheriffs will have to hunt you down and/or revert your
changes if things go bad.

Try server docs:
http://www.chromium.org/developers/try-server-usage

Build waterfall (you definitely want to bookmark this, it'll become a regular
part of your existence):
http://build.chromium.org/buildbot/waterfall/console

IRC channel (where people will try to contact you first if you break the build):
http://webchat.freenode.net/ (channel #chromium)

Expand Messages | Collapse Messages