Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Side by Side Diff: src/liveedit.cc

Issue 2100010: Fix buffer overflow in liveedit.... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 970 matching lines...) Expand 10 before | Expand all | Expand 10 after
981 981
982 DeleteArray(buffer_); 982 DeleteArray(buffer_);
983 buffer_ = new_buffer; 983 buffer_ = new_buffer;
984 buffer_size_ = new_buffer_size; 984 buffer_size_ = new_buffer_size;
985 } 985 }
986 986
987 RelocInfoWriter reloc_info_writer_; 987 RelocInfoWriter reloc_info_writer_;
988 byte* buffer_; 988 byte* buffer_;
989 int buffer_size_; 989 int buffer_size_;
990 990
991 static const int kBufferGap = 8; 991 static const int kBufferGap = RelocInfoWriter::kMaxSize;
992 static const int kMaximalBufferSize = 512*MB; 992 static const int kMaximalBufferSize = 512*MB;
993 }; 993 };
994 994
995 // Patch positions in code (changes relocation info section) and possibly 995 // Patch positions in code (changes relocation info section) and possibly
996 // returns new instance of code. 996 // returns new instance of code.
997 static Handle<Code> PatchPositionsInCode(Handle<Code> code, 997 static Handle<Code> PatchPositionsInCode(Handle<Code> code,
998 Handle<JSArray> position_change_array) { 998 Handle<JSArray> position_change_array) {
999 999
1000 RelocInfoBuffer buffer_writer(code->relocation_size(), 1000 RelocInfoBuffer buffer_writer(code->relocation_size(),
1001 code->instruction_start()); 1001 code->instruction_start());
(...skipping 457 matching lines...) Expand 10 before | Expand all | Expand 10 after
1459 1459
1460 bool LiveEditFunctionTracker::IsActive() { 1460 bool LiveEditFunctionTracker::IsActive() {
1461 return false; 1461 return false;
1462 } 1462 }
1463 1463
1464 #endif // ENABLE_DEBUGGER_SUPPORT 1464 #endif // ENABLE_DEBUGGER_SUPPORT
1465 1465
1466 1466
1467 1467
1468 } } // namespace v8::internal 1468 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698