Issue 2099012: Cancels an ongoing IME composition when receiving an IME_CANCEL_COMPOSITION e...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2099012: Cancels an ongoing IME composition when receiving an IME_CANCEL_COMPOSITION e... (Closed)

Created:
10 years, 7 months ago by Hironori Bono

Modified:
9 years, 7 months ago

Reviewers:
tony, ojan

CC:
chromium-reviews, jam+cc_chromium.org, brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cancels an ongoing IME composition when receiving an IME_CANCEL_COMPOSITION event on Windows. This change just adds ImeInput::CancelIME() and use it when receiving an IME_CANCEL_COMPOSITION event. (I'm not sure it works well with all IMEs, though.) BUG=9883 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48470

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -3 lines)			Patch
M	chrome/browser/ime_input.h	View		3 chunks	+8 lines, -2 lines	0 comments	Download
M	chrome/browser/ime_input.cc	View	1	2 chunks	+12 lines, -1 line	0 comments	Download
M	chrome/browser/renderer_host/render_widget_host_view_win.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Hironori Bono

Tony, This change just ports your IME change <http://codereview.chromium.org/2095024> to Windows. Even though I have ...

10 years, 7 months ago (2010-05-21 09:57:01 UTC) #1

tony

10 years, 7 months ago (2010-05-24 06:19:58 UTC) #2

Thank you for this change!  Yes, this change LGTM (seems to work with MS IME).

Expand Messages | Collapse Messages