Adding a bit of logging to track down the reason for recent "LaunchBrowser(br...

chrome_frame/test/chrome_frame_test_utils.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/test/chrome_frame_test_utils.h"
 
 #include <atlbase.h>
 #include <atlwin.h>
 #include <iepmapi.h>
 #include <sddl.h>
@@ skipping 121 matching lines @@
   return command;
 }
 
 base::ProcessHandle LaunchExecutable(const std::wstring& executable,
                                      const std::wstring& argument) {
   base::ProcessHandle process = NULL;
   std::wstring path = GetExecutableAppPath(executable);
   if (path.empty()) {
     path = FormatCommandForApp(executable, argument);
     if (path.empty()) {
-      DLOG(ERROR) << "Failed to find executable: " << executable;
+      LOG(ERROR) << "Failed to find executable: " << executable;
     } else {
       CommandLine cmdline = CommandLine::FromString(path);
-      base::LaunchApp(cmdline, false, false, &process);
+      if (!base::LaunchApp(cmdline, false, false, &process)) {
+        LOG(ERROR) << "LaunchApp failed: " << ::GetLastError();
+      }
     }
   } else {
     CommandLine cmdline((FilePath(path)));
     cmdline.AppendLooseValue(argument);
-    base::LaunchApp(cmdline, false, false, &process);
+    if (!base::LaunchApp(cmdline, false, false, &process)) {
+      LOG(ERROR) << "LaunchApp failed: " << ::GetLastError();
+    }
   }
   return process;
 }
 
 base::ProcessHandle LaunchFirefox(const std::wstring& url) {
   return LaunchExecutable(kFirefoxImageName, url);
 }
 
 base::ProcessHandle LaunchSafari(const std::wstring& url) {
   return LaunchExecutable(kSafariImageName, url);
@@ skipping 30 matching lines @@
 base::ProcessHandle LaunchIEOnVista(const std::wstring& url) {
   typedef HRESULT (WINAPI* IELaunchURLPtr)(
       const wchar_t* url,
       PROCESS_INFORMATION *pi,
       VOID *info);
 
   IELaunchURLPtr launch;
   PROCESS_INFORMATION pi = {0};
   IELAUNCHURLINFO  info = {sizeof info, 0};
   HMODULE h = LoadLibrary(L"ieframe.dll");
-  if (!h)
+  if (!h) {
+    LOG(ERROR) << "Failed to load ieframe.dll: " << ::GetLastError();
     return NULL;
+  }
   launch = reinterpret_cast<IELaunchURLPtr>(GetProcAddress(h, "IELaunchURL"));
+  CHECK(launch);
   HRESULT hr = launch(url.c_str(), &pi, &info);
   FreeLibrary(h);
-  if (SUCCEEDED(hr))
+  if (SUCCEEDED(hr)) {
     CloseHandle(pi.hThread);
+  } else {
+    LOG(ERROR) << ::StringPrintf("IELaunchURL failed: 0x%08X", hr);
+  }
   return pi.hProcess;
 }
 
 base::ProcessHandle LaunchIE(const std::wstring& url) {
   if (win_util::GetWinVersion() >= win_util::WINVERSION_VISTA) {
     return LaunchIEOnVista(url);
   } else {
     return LaunchExecutable(kIEImageName, url);
   }
 }
@@ skipping 658 matching lines @@
   if (GetInstalledIEVersion() == IE_8) {
     profile_path = GetProfilePath(kIEProfileName);
   } else {
     profile_path = GetIETemporaryFilesFolder();
     profile_path = profile_path.Append(L"Google Chrome Frame");
   }
   return profile_path;
 }
 
 }  // namespace chrome_frame_test