Issue 2099002: Better error message when WebGL not found.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2099002: Better error message when WebGL not found. (Closed)

Created:
10 years, 7 months ago by petersont

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
o3d-review_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

When a demo on the o3d-webgl site gets opened in an ordinary browser that doesn't support WebGL yet, the error message just says "WebGL context not found". Now it provides a link with more information. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47312

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -11 lines)			Patch
	M	samples/o3d-webgl/client.js	View		6 chunks	+31 lines, -6 lines	0 comments	Download
	M	samples/o3djs/webgl.js	View	1 2 3	4 chunks	+47 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

Some of the changes in client.js look unrelated to the improvement of the error message ...

10 years, 7 months ago (2010-05-14 01:10:59 UTC) #2

petersont

10 years, 7 months ago (2010-05-14 21:17:29 UTC) #3

http://codereview.chromium.org/2099002/diff/4001/5002
File samples/o3djs/webgl.js (right):

http://codereview.chromium.org/2099002/diff/4001/5002#newcode155
samples/o3djs/webgl.js:155: 'Make sure you are using a WebGL cabable browser ' +
On 2010/05/14 01:10:59, kbr wrote:
> capable
> 

Done.

Expand Messages | Collapse Messages