Issue 2097001: Add new ipc message utility and new message types in preparation for OOP impo...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2097001: Add new ipc message utility and new message types in preparation for OOP impo... (Closed)

Created:
10 years, 7 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
brettw, jeremy

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add new ipc message utility and new message types in preparation for OOP import patch. This patch adds the ability to move a set across IPC, and adds two new message types. BUG=18774 TEST= none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47172

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -1 line)			Patch
	M	ipc/ipc_message_utils.h	View		3 chunks	+30 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jeremy

10 years, 7 months ago (2010-05-13 21:01:59 UTC) #3

LGTM

http://codereview.chromium.org/2097001/diff/1/2
File ipc/ipc_message_utils.h (right):

http://codereview.chromium.org/2097001/diff/1/2#newcode500
ipc/ipc_message_utils.h:500: l->append(L"<std::set>");
Should LogParam() all items in the set (see std::vector above)

Expand Messages | Collapse Messages