Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2096010: Disabling sync integration tests that depend on static data. (Closed)

Created:
10 years, 7 months ago by Raghu Simha
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana
Base URL:
git://codf21.jail/chromium.git
Visibility:
Public.

Description

Patch from Raghu Simha (rsimha@chromium.org) Disabling sync integration tests that depend on static data. The following tests need to be rewritten without a dependency on static data. LiveSyncTestDefaultIEFavorites.SC_BootStrapWithDefaultIEFavorites LiveSyncTestComplexHierarchy800BM.SC_BootStrapWithComplexBMHierarchy LiveSyncTestHugeHierarchy5500BM.SC_BootStrapWithHugeBMs LiveSyncTestPrePopulatedHistory1K.SC_AddFirstBMWithFavicon LiveSyncTestBasicHierarchy50BM.MC_PushExistingBMsToSecondClient LiveSyncTestBasicHierarchy50BMBothClients.MC_FirstUseExistingSameBMModelBothClients BUG=43917 TEST=sync_integration_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc View 6 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Raghu Simha
10 years, 7 months ago (2010-05-18 22:45:40 UTC) #1
ncarter (slow)
10 years, 7 months ago (2010-05-18 23:50:41 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698