Issue 2096003: Refactor gcl.py to use a similar pattern for every commands.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2096003: Refactor gcl.py to use a similar pattern for every commands. (Closed)

Created:
10 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Visibility:
Public.

Description

Refactor gcl.py to use a similar pattern for every commands. The next step will be to generate help automatically and remove the command check loop. TEST=not much BUG=me Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47291

Patch Set 1 #

Patch Set 2 : Small fix #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+169 lines, -153 lines)			Patch
	M	gcl.py	View	1	15 chunks	+150 lines, -79 lines	0 comments	Download
	M	tests/gcl_unittest.py	View		7 chunks	+19 lines, -74 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

bradn

10 years, 7 months ago (2010-05-14 17:55:12 UTC) #2

LGTM, while you're in there maybe switch the quote type one way or the other,
nah whatever.

Expand Messages | Collapse Messages