Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: webkit/tools/test_shell/notification_presenter.cc

Issue 2095010: Revert r46500 in an attempt to verify a perf regression on the Mac bots. (Closed)
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/tools/test_shell/notification_presenter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/tools/test_shell/notification_presenter.cc
diff --git a/webkit/tools/test_shell/notification_presenter.cc b/webkit/tools/test_shell/notification_presenter.cc
index 163b181ff291278e4ce621bc2abbab6ec47a9371..e0402d29a9e52490c291b2903f6e042979a19ca3 100644
--- a/webkit/tools/test_shell/notification_presenter.cc
+++ b/webkit/tools/test_shell/notification_presenter.cc
@@ -26,23 +26,11 @@ void TestNotificationPresenter::grantPermission(const std::string& origin) {
// The output from all these methods matches what DumpRenderTree produces.
bool TestNotificationPresenter::show(const WebNotification& notification) {
- if (!notification.replaceId().isEmpty()) {
- std::string replace_id(notification.replaceId().utf8());
- if (replacements_.find(replace_id) != replacements_.end())
- printf("REPLACING NOTIFICATION %s\n",
- replacements_.find(replace_id)->second.c_str());
-
- WebString identifier = notification.isHTML() ?
- notification.url().spec().utf16() : notification.title();
- replacements_[replace_id] = identifier.utf8();
- }
-
if (notification.isHTML()) {
printf("DESKTOP NOTIFICATION: contents at %s\n",
notification.url().spec().data());
} else {
- printf("DESKTOP NOTIFICATION:%s icon %s, title %s, text %s\n",
- notification.dir() == "rtl" ? "(RTL)" : "",
+ printf("DESKTOP NOTIFICATION: icon %s, title %s, text %s\n",
notification.iconURL().isEmpty() ? "" :
notification.iconURL().spec().data(),
notification.title().isEmpty() ? "" :
« no previous file with comments | « webkit/tools/test_shell/notification_presenter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698