Issue 2094005: Add stack traces to mjsunit tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2094005: Add stack traces to mjsunit tests. (Closed)

Created:
10 years, 7 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
antonm

CC:
v8-dev

Visibility:
Public.

Description

Add stack traces to mjsunit tests. Committed: http://code.google.com/p/v8/source/detail?r=4654

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	samples/shell.cc	View		1 chunk	+5 lines, -0 lines	2 comments	Download
	M	test/mjsunit/mjsunit.js	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

antonm

Cool. LGTM. http://codereview.chromium.org/2094005/diff/1/2 File samples/shell.cc (right): http://codereview.chromium.org/2094005/diff/1/2#newcode302 samples/shell.cc:302: v8::String::Utf8Value stack_trace(try_catch->StackTrace()); won't it be too verbose? ...

10 years, 7 months ago (2010-05-14 09:49:07 UTC) #2

Vitaly Repeshko

10 years, 7 months ago (2010-05-14 09:59:21 UTC) #3

http://codereview.chromium.org/2094005/diff/1/2
File samples/shell.cc (right):

http://codereview.chromium.org/2094005/diff/1/2#newcode302
samples/shell.cc:302: v8::String::Utf8Value
stack_trace(try_catch->StackTrace());
On 2010/05/14 09:49:07, antonm wrote:
> won't it be too verbose?  maybe hide it behind a flag?

When used in our tests this reports failures so hopefully it won't be too
verbose. When used as a javascript shell printing full trace is a sensible thing
to do.

Expand Messages | Collapse Messages