Initialize the ChromeFrame request manager with the container interface in th...

Initialize the ChromeFrame request manager with the container interface in the constructor instead of FinalConstruct as there are
codepaths in which the base FinalConstruct is not called.

Bug=44465
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47890

[amit, 2010-05-21 00:35:39]

Ok

On May 20, 2010 5:33 PM, <ananta@chromium.org> wrote:
> Reviewers: amit,
>
> Description:
> Initialize the ChromeFrame request manager with the container interface in

> the
> constructor instead of FinalConstruct as there are
> codepaths in which the base FinalConstruct is not called.
>
> Bug=44465
>
>
> Please review this at http://codereview.chromium.org/2093011/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> M chrome_frame/chrome_frame_activex_base.h
>
>
> Index: chrome_frame/chrome_frame_activex_base.h
> ===================================================================
> --- chrome_frame/chrome_frame_activex_base.h (revision 47846)
> +++ chrome_frame/chrome_frame_activex_base.h (working copy)
> @@ -176,9 +176,11 @@
> ChromeFrameActivexBase()
> : ready_state_(READYSTATE_UNINITIALIZED) {
> m_bWindowOnly = TRUE;
> + url_fetcher_.set_container(static_cast<IDispatch*>(this));
> }
>
> ~ChromeFrameActivexBase() {
> + url_fetcher_.set_container(NULL);
> }
>
> DECLARE_OLEMISC_STATUS(OLEMISC_RECOMPOSEONRESIZE | OLEMISC_CANTLINKINSIDE
|
> @@ -260,7 +262,6 @@
> IE_8,
> IE_8 + 1);
> }
> - url_fetcher_.set_container(static_cast<IDispatch*>(this));
> return S_OK;
> }
>
>
>