Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2093011: Initialize the ChromeFrame request manager with the container interface in th... (Closed)

Created:
10 years, 7 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Initialize the ChromeFrame request manager with the container interface in the constructor instead of FinalConstruct as there are codepaths in which the base FinalConstruct is not called. Bug=44465 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47890

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome_frame/chrome_frame_activex_base.h View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
ananta
10 years, 7 months ago (2010-05-21 00:33:46 UTC) #1
amit
10 years, 7 months ago (2010-05-21 00:35:39 UTC) #2
Ok

On May 20, 2010 5:33 PM, <ananta@chromium.org> wrote:
> Reviewers: amit,
>
> Description:
> Initialize the ChromeFrame request manager with the container interface in

> the
> constructor instead of FinalConstruct as there are
> codepaths in which the base FinalConstruct is not called.
>
> Bug=44465
>
>
> Please review this at http://codereview.chromium.org/2093011/show
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
> M chrome_frame/chrome_frame_activex_base.h
>
>
> Index: chrome_frame/chrome_frame_activex_base.h
> ===================================================================
> --- chrome_frame/chrome_frame_activex_base.h (revision 47846)
> +++ chrome_frame/chrome_frame_activex_base.h (working copy)
> @@ -176,9 +176,11 @@
> ChromeFrameActivexBase()
> : ready_state_(READYSTATE_UNINITIALIZED) {
> m_bWindowOnly = TRUE;
> + url_fetcher_.set_container(static_cast<IDispatch*>(this));
> }
>
> ~ChromeFrameActivexBase() {
> + url_fetcher_.set_container(NULL);
> }
>
> DECLARE_OLEMISC_STATUS(OLEMISC_RECOMPOSEONRESIZE | OLEMISC_CANTLINKINSIDE
|
> @@ -260,7 +262,6 @@
> IE_8,
> IE_8 + 1);
> }
> - url_fetcher_.set_container(static_cast<IDispatch*>(this));
> return S_OK;
> }
>
>
>

Powered by Google App Engine
This is Rietveld 408576698