Issue 209031: Switch to using vkey constants rather than hardcoded decimal values...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209031: Switch to using vkey constants rather than hardcoded decimal values... (Closed)

Created:
11 years, 3 months ago by pink (ping after 24hrs)

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Switch to using vkey constants rather than hardcoded decimal values BUG=none TEST=switching tabs via key combos should still work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26573

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -17 lines)			Patch
	M	chrome/browser/global_keyboard_shortcuts_mac.mm	View	1	2 chunks	+23 lines, -17 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

11 years, 3 months ago (2009-09-18 14:45:11 UTC) #2

LG (went through Events.h and checked the numbers match the constants).

Please update the CL description with "Also map cmd-1-8 to 'select tab 1-8',
cmd-9 to 'select last tab'".

Expand Messages | Collapse Messages