Issue 209014: Hide source for builtin functions in toString() call....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209014: Hide source for builtin functions in toString() call.... (Closed)

Created:
11 years, 3 months ago by Jan de Mooij

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Hide source for builtin functions in toString() call. BUG=438 TEST=regress-438.js

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -7 lines)			Patch
M	AUTHORS	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	src/v8natives.js	View	2 chunks	+1 line, -7 lines	0 comments	Download
A	test/mjsunit/regress/regress-438.js	View	1 chunk	+33 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Mads Ager (chromium)

LGTM Thanks for the patch. Before I can put this into the V8 code base, ...

11 years, 3 months ago (2009-09-17 09:38:29 UTC) #2

Jan de Mooij

I signed the license about 30 minutes ago. Thanks for review.

11 years, 3 months ago (2009-09-17 09:44:16 UTC) #3

Mads Ager (chromium)

11 years, 3 months ago (2009-09-17 11:11:12 UTC) #4

Thanks Jan.  Landed in bleeding_edge revision 2913.