Issue 209013: Add Object::IsDirty function in the API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 209013: Add Object::IsDirty function in the API. (Closed)

Created:
11 years, 3 months ago by Christian Plesner Hansen

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add Object::IsDirty function in the API. Committed: http://code.google.com/p/v8/source/detail?r=2911

Patch Set 1 #

Total comments: 2

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -0 lines)			Patch
M	include/v8.h	View	1 chunk	+9 lines, -0 lines	0 comments	Download
M	src/api.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+15 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

LGTM http://codereview.chromium.org/209013/diff/1/4 File src/objects.cc (right): http://codereview.chromium.org/209013/diff/1/4#newcode480 Line 480: Object* cons_obj = map()->constructor(); How about just ...

11 years, 3 months ago (2009-09-17 08:46:18 UTC) #2

Christian Plesner Hansen

http://codereview.chromium.org/209013/diff/1/4 File src/objects.cc (right): http://codereview.chromium.org/209013/diff/1/4#newcode480 Line 480: Object* cons_obj = map()->constructor(); The reason I used ...

11 years, 3 months ago (2009-09-17 08:53:15 UTC) #3

Mads Ager (chromium)

11 years, 3 months ago (2009-09-17 08:56:12 UTC) #4

On 2009/09/17 08:53:15, Christian Plesner Hansen wrote:
> http://codereview.chromium.org/209013/diff/1/4
> File src/objects.cc (right):
> 
> http://codereview.chromium.org/209013/diff/1/4#newcode480
> Line 480: Object* cons_obj = map()->constructor();
> The reason I used cons_obj is that we don't know if it really is the
constructor
> until after the check below.  At this point it's just some object stored in
the
> constructor field.

OK, LGTM

Expand Messages | Collapse Messages