Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 209012: Minor changes to the native array construct code... (Closed)

Created:
11 years, 3 months ago by sgjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Minor changes to the native array construct code Named a constant and added an assert to get notified when related constants change. Removed reloading of the Array function when Array is called as a constructor as the Array function is preserved in edi. This - unlike r2908 and r2909 - both compiles and passes the tests. Committed: http://code.google.com/p/v8/source/detail?r=2940

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/ia32/builtins-ia32.cc View 1 6 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 3 months ago (2009-09-17 08:18:54 UTC) #1
Mads Ager (chromium)
11 years, 3 months ago (2009-09-17 08:31:02 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698