Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 209004: Use delegate protocols present in the 10.6 SDK (Closed)

Created:
11 years, 3 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
TVL
CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, pam+watch_chromium.org, Paweł Hajdan Jr., brettw, Ben Goodger (Google)
Visibility:
Public.

Description

Use delegate protocols present in the 10.6 SDK. For previous SDKs, provide empty protocol definitions for compatibility. BUG=20925 TEST=build Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26477

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -15 lines) Patch
M base/base.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A base/cocoa_protocols_mac.h View 1 1 chunk +36 lines, -0 lines 0 comments Download
M chrome/browser/app_modal_dialog_mac.mm View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.h View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_mac.mm View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/autocomplete_text_field_unittest.mm View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bar_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_bubble_controller.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_button_cell.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/bookmark_editor_controller.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/browser_window_controller.mm View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/download_item_cell.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/download_shelf_controller.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/cocoa/hung_renderer_controller.h View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/cocoa/tab_window_controller.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
11 years, 3 months ago (2009-09-16 23:19:25 UTC) #1
TVL
11 years, 3 months ago (2009-09-17 03:18:49 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698