Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2090006: Use new grub2 variables to boot from the device with the bootloader (Closed)

Created:
10 years, 7 months ago by Bill Richardson
Modified:
9 years, 6 months ago
Reviewers:
Nick Sanders, adlr
CC:
chromium-os-reviews_chromium.org, dneiss, adlr
Base URL:
ssh://git@chromiumos-git//chromeos
Visibility:
Public.

Description

Use new grub2 variables to boot from the device with the bootloader See http://codereview.chromium.org/2113004/show for details. This also adds a script to allow manual selection of the preferred image (A or B). BUG=none

Patch Set 1 #

Total comments: 3

Patch Set 2 : respond to feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -24 lines) Patch
M src/platform/installer/chromeos-common.sh View 1 chunk +12 lines, -0 lines 0 comments Download
M src/platform/installer/chromeos-install View 1 chunk +2 lines, -10 lines 0 comments Download
A src/platform/installer/chromeos-setimage View 1 1 chunk +71 lines, -0 lines 0 comments Download
M src/scripts/build_image View 1 chunk +7 lines, -14 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bill Richardson
10 years, 7 months ago (2010-05-14 18:43:16 UTC) #1
adlr
http://codereview.chromium.org/2090006/diff/1/2 File src/platform/installer/chromeos-setimage (right): http://codereview.chromium.org/2090006/diff/1/2#newcode41 src/platform/installer/chromeos-setimage:41: # Unless you pass --run_as_root, you can't be root ...
10 years, 7 months ago (2010-05-14 21:18:44 UTC) #2
Bill Richardson
10 years, 7 months ago (2010-05-14 23:54:13 UTC) #3
Bill Richardson
http://codereview.chromium.org/2090006/diff/1/2 File src/platform/installer/chromeos-setimage (right): http://codereview.chromium.org/2090006/diff/1/2#newcode41 src/platform/installer/chromeos-setimage:41: # Unless you pass --run_as_root, you can't be root ...
10 years, 7 months ago (2010-05-14 23:54:28 UTC) #4
adlr
10 years, 7 months ago (2010-05-14 23:58:12 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698