Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2089023: Add vim temporary files to .gitignore. (Closed)

Created:
10 years, 7 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Visibility:
Public.

Description

Add vim temporary files to .gitignore. Ignore ".*.sw?". BUG=none TEST=git+vim users should no longer see temporary files Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48082

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gitignore View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
viettrungluu
10 years, 7 months ago (2010-05-24 20:59:44 UTC) #1
Robert Sesek
http://codereview.chromium.org/2089023/diff/1/2 File .gitignore (right): http://codereview.chromium.org/2089023/diff/1/2#newcode13 .gitignore:13: .*.sw? Why "sw?" instead of "sw*"
10 years, 7 months ago (2010-05-24 21:00:59 UTC) #2
viettrungluu
On 2010/05/24 21:00:59, rsesek wrote: > http://codereview.chromium.org/2089023/diff/1/2 > File .gitignore (right): > > http://codereview.chromium.org/2089023/diff/1/2#newcode13 > ...
10 years, 7 months ago (2010-05-24 21:03:15 UTC) #3
Robert Sesek
10 years, 7 months ago (2010-05-24 21:04:58 UTC) #4
On 2010/05/24 21:03:15, viettrungluu wrote:
> On 2010/05/24 21:00:59, rsesek wrote:
> > http://codereview.chromium.org/2089023/diff/1/2
> > File .gitignore (right):
> > 
> > http://codereview.chromium.org/2089023/diff/1/2#newcode13
> > .gitignore:13: .*.sw?
> > Why "sw?" instead of "sw*"
> 
> <shrug> Because I don't want to ignore .*.sw files? Nor .*.swfoobar?
Admittedly,
> I don't really know what vim does once it runs out of single letters, but I
> figured being as specific as possible is safer/better.

Ok. If it becomes a problem, I'm fine with revising then. LGTM.

Powered by Google App Engine
This is Rietveld 408576698