Issue 2089019: Add unit tests for Nigori permute and decrypt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2089019: Add unit tests for Nigori permute and decrypt. (Closed)

Created:
10 years, 7 months ago by albertb

Modified:
9 years, 3 months ago

Reviewers:
wtc

CC:
chromium-reviews, ben+cc_chromium.org, ncarter (slow), Paweł Hajdan Jr., tim (not reviewing), idana

Visibility:
Public.

Add unit tests for Nigori permute and decrypt. BUG=none TEST=NigoriTest.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47745

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -0 lines)			Patch
	M	chrome/browser/sync/util/nigori_unittest.cc	View		1 chunk	+29 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

albertb

Hi Wan-Teh, After our discussion yesterday, I added a of couple unit tests for Nigori. ...

10 years, 7 months ago (2010-05-19 21:43:37 UTC) #1

wtc

10 years, 7 months ago (2010-05-19 22:40:12 UTC) #2

LGTM!

My only suggestion is to move the new Permute and
Decrypt tests to be next to similar tests.