Issue 2086024: Repair Visual Studio build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2086024: Repair Visual Studio build (Closed)

Created:
10 years, 7 months ago by yurys

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix v8_base.vcproj: add dtoa.cc and fixed-dtoa.cc to dtoa project. Committed: http://code.google.com/p/v8/source/detail?r=4719

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -0 lines)			Patch
	M	tools/visual_studio/v8_base.vcproj	View	1 2	1 chunk	+24 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM, but please add the .h files as well, and don't you need fast-dtoa.cc/fast-dtoa.h as ...

10 years, 7 months ago (2010-05-26 06:52:30 UTC) #2

yurys

10 years, 7 months ago (2010-05-26 08:02:33 UTC) #3

On 2010/05/26 06:52:30, Søren Gjesse wrote:
> LGTM, but please add the .h files as well, and don't you need
> fast-dtoa.cc/fast-dtoa.h as well?
Done. Added .h files as well as fast-dtoa.{cc,h}. In original patch I added only
the files that were required for the project to be linked without errors.

Expand Messages | Collapse Messages