Issue 2086018: Add implementation of CreateObject.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2086018: Add implementation of CreateObject. (Closed)

Created:
10 years, 7 months ago by darin (slow to review)

Modified:
9 years, 7 months ago

Reviewers:
brettw

CC:
chromium-reviews, jam, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Add implementation of CreateObject. R=brettw BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47892

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+326 lines, -5 lines)			Patch
	M	DEPS	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	webkit/glue/plugins/pepper_var.cc	View		7 chunks	+325 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

brettw

10 years, 7 months ago (2010-05-20 21:09:45 UTC) #2

I'm sure you made a reference counting error, but I couldn't find it, so LGTM.