Issue 2086005: Incorporate feedback from issue 679 and issue 690

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2086005: Incorporate feedback from issue 679 and issue 690 (Closed)

Created:
10 years, 7 months ago by Kasper Lund

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Incorporate feedback from issue 679 and issue 690 into the benchmark suite thus forming a new candidate benchmark revision: * Remove dead code from RayTrace benchmark. * Avoid repeated number-to-string conversion in Splay. Committed: http://code.google.com/p/v8/source/detail?r=4658

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -40 lines)			Patch
M	benchmarks/README.txt	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	benchmarks/base.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	benchmarks/raytrace.js	View	2 chunks	+0 lines, -31 lines	0 comments	Download
M	benchmarks/revisions.html	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	benchmarks/run.html	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	benchmarks/splay.js	View	2 chunks	+6 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages