add optional facory builds to archive_build

add optional facory builds to archive_build

[Nick Sanders, 2010-05-20 09:13:40]

Optional arguments to build factory packages. If built they are put in a
separate zipfile.

[sosa, 2010-05-20 17:43:03]

Can you update and rebase with my changes and re upload?  It's hard to review
without my changes.  I just committed them 30 min ago.

http://codereview.chromium.org/2084013/diff/1/2
File src/scripts/archive_build.sh (right):

http://codereview.chromium.org/2084013/diff/1/2#newcode24
src/scripts/archive_build.sh:24: "The board to build packages for."
your 4 indent has introduced some lines here that are greater than 80 chars. 
either revert back to 2 line indent (we're inconsistent in bash script atm but
google style does indicate 2 line indent for continuations for bash) or fix the
80 chars

http://codereview.chromium.org/2084013/diff/1/2#newcode38
src/scripts/archive_build.sh:38: DEFINE_boolean factory_install_mod \
Can't you combine these two flags into one + test mod?

[Nick Sanders, 2010-05-20 21:21:31]

integrated

[sosa, 2010-05-20 23:29:09]

http://codereview.chromium.org/2084013/diff/5001/6001
File src/scripts/archive_build.sh (right):

http://codereview.chromium.org/2084013/diff/5001/6001#newcode39
src/scripts/archive_build.sh:39: "Modify image for factory install purposes"
Do you have a use case where only one of these would be set?

http://codereview.chromium.org/2084013/diff/5001/6001#newcode126
src/scripts/archive_build.sh:126: # Modify image for test if flag set.
Change this comment

http://codereview.chromium.org/2084013/diff/5001/6001#newcode127
src/scripts/archive_build.sh:127: if [ $FLAGS_factory_test_mod -eq $FLAGS_TRUE ]
All 3 of these if fi blocks do the same thing, can you functionalize this

http://codereview.chromium.org/2084013/diff/5001/6001#newcode140
src/scripts/archive_build.sh:140: # Modify image for test if flag set.
Change comment.

[Nick Sanders, 2010-05-21 01:04:16]

http://codereview.chromium.org/2084013/diff/5001/6001
File src/scripts/archive_build.sh (right):

http://codereview.chromium.org/2084013/diff/5001/6001#newcode39
src/scripts/archive_build.sh:39: "Modify image for factory install purposes"
On 2010/05/20 23:29:09, sosa wrote:
> Do you have a use case where only one of these would be set?  

Yes, technically the factory_install is supposed to be build from a different
base image, but Ken and djmm mentioned that getting that regression set up was
significantly harder.

http://codereview.chromium.org/2084013/diff/5001/6001#newcode126
src/scripts/archive_build.sh:126: # Modify image for test if flag set.
On 2010/05/20 23:29:09, sosa wrote:
> Change this comment

Done.

http://codereview.chromium.org/2084013/diff/5001/6001#newcode127
src/scripts/archive_build.sh:127: if [ $FLAGS_factory_test_mod -eq $FLAGS_TRUE ]
On 2010/05/20 23:29:09, sosa wrote:
> All 3 of these if fi blocks do the same thing, can you functionalize this

Done.

http://codereview.chromium.org/2084013/diff/5001/6001#newcode140
src/scripts/archive_build.sh:140: # Modify image for test if flag set.
On 2010/05/20 23:29:09, sosa wrote:
> Change comment.

Done.

[sosa, 2010-05-21 01:08:50]

lgtm

http://codereview.chromium.org/2084013/diff/11001/12001
File src/scripts/archive_build.sh (right):

http://codereview.chromium.org/2084013/diff/11001/12001#newcode122
src/scripts/archive_build.sh:122: mv "$SRC_IMAGE" "${OUTPUT_IMAGE}"
be consistent with use of {}'s in ${var}

[Nick Sanders, 2010-05-21 03:36:54]

BUG=3397
TEST="./archive_build.sh --factory_test_mod --factory_install_mod,
factory_image.zip is output"